Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings indent (fbx-545) #737

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix settings indent (fbx-545) #737

wants to merge 3 commits into from

Conversation

mfe
Copy link
Collaborator

@mfe mfe commented Jan 16, 2025

Purpose of this PR

Ticket/Jira #: (fbx-545)

An indent was unintentionally removed in project setting and was preventing straightforward toggling of checkboxes (you had to click next to the checkbox).

Testing

Functional Testing status:

Manual testing

Performance Testing status:

Documentation & UX Writing

User facing text to review Details
User interface N
Public API docs N
Changelog Y
Documentation halo effect Jira link
User manual N
Other docs N

Additional information

Note to reviewers:

Reminder:

@mfe mfe requested review from LeoUnity and windxu88 January 17, 2025 09:44
Copy link
Contributor

@windxu88 windxu88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can reproduce the issue with 5.1.2 on my M1 mac and can confirm the issue has disappeared with 5.1.3 local tarball.
The only CI failure on ARM64 Win is known and is being investigated by another team. It is an network issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants